Skip to content

[Merged by Bors] - chore: use notation3 for Ordinal.typeLT#39798

Closed
vihdzp wants to merge 2 commits into
leanprover-community:masterfrom
vihdzp:typelt
Closed

[Merged by Bors] - chore: use notation3 for Ordinal.typeLT#39798
vihdzp wants to merge 2 commits into
leanprover-community:masterfrom
vihdzp:typelt

Conversation

@vihdzp

@vihdzp vihdzp commented May 25, 2026

Copy link
Copy Markdown
Collaborator

This creates a delaborator, which avoids goals from looking like (type fun x1 x2 ↦ x1 < x2) < (type fun x1 x2 ↦ x1 < x2).

Open in Gitpod

@vihdzp
vihdzp requested a review from YaelDillies May 25, 2026 01:32
@vihdzp vihdzp added the t-set-theory Set theory label May 25, 2026
@github-actions

github-actions Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown

PR summary d21f60a088

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

No changes to strong technical debt.
No changes to weak technical debt.

@plp127 plp127 added the easy < 20s of review time. See the lifecycle page for guidelines. label May 25, 2026
YaelDillies
YaelDillies reviewed May 25, 2026
View reviewed changes

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a test with #guard_msgs?

@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label May 25, 2026
@YaelDillies YaelDillies self-assigned this May 25, 2026
@vihdzp

vihdzp commented May 25, 2026

Copy link
Copy Markdown
Collaborator Author

Where should that test go? Directly below the notation? In a new file?

@YaelDillies

YaelDillies commented May 25, 2026

Copy link
Copy Markdown
Contributor

Directly below is okay

@vihdzp vihdzp removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 25, 2026
YaelDillies
YaelDillies approved these changes May 25, 2026
View reviewed changes

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions

github-actions Bot commented May 25, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 25, 2026
@riccardobrasca

riccardobrasca commented Jun 3, 2026

Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 3, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jun 3, 2026
@vihdzp
chore: use notation3 for Ordinal.typeLT (#39798)
da26519 
This creates a delaborator, which avoids goals from looking like `(type fun x1 x2 ↦ x1 < x2) < (type fun x1 x2 ↦ x1 < x2)`.
@mathlib-bors

mathlib-bors Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: use notation3 for Ordinal.typeLT [Merged by Bors] - chore: use notation3 for Ordinal.typeLT Jun 3, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 3, 2026
Bergschaf pushed a commit to Bergschaf/mathlib4 that referenced this pull request Jun 3, 2026
@vihdzp @Bergschaf
chore: use notation3 for Ordinal.typeLT (leanprover-community#39798)
7c8049a 
This creates a delaborator, which avoids goals from looking like `(type fun x1 x2 ↦ x1 < x2) < (type fun x1 x2 ↦ x1 < x2)`.
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
@vihdzp @ReemMelamed
chore: use notation3 for Ordinal.typeLT (leanprover-community#39798)
efc3015 
This creates a delaborator, which avoids goals from looking like `(type fun x1 x2 ↦ x1 < x2) < (type fun x1 x2 ↦ x1 < x2)`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees

@YaelDillies YaelDillies

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-set-theory Set theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vihdzp @YaelDillies @riccardobrasca @plp127